Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DevOverlay] Floating Header and Bottom Stacks #74581

Merged
merged 7 commits into from
Jan 10, 2025
Merged

[DevOverlay] Floating Header and Bottom Stacks #74581

merged 7 commits into from
Jan 10, 2025
+129 −22

Conversation

devjiwonchoi
Copy link
Member

@devjiwonchoi devjiwonchoi commented Jan 7, 2025 •
edited
Loading

This PR moved existing pagination and version info to a floating header above the overlay.
Moved the Bottom Stacks inside the dialog component and modified position as well.

CleanShot 2025-01-07 at 20 31 24

Closes NDX-634

@ijjk ijjk added created-by: Next.js team PRs by the Next.js team. type: next labels Jan 7, 2025
This was referenced Jan 7, 2025
Merged
Merged
Merged
@devjiwonchoi Graphite App
Copy link
Member Author

devjiwonchoi commented Jan 7, 2025 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

@devjiwonchoi devjiwonchoi mentioned this pull request Jan 7, 2025
Merged
@devjiwonchoi devjiwonchoi marked this pull request as ready for review January 7, 2025 11:43
@ijjk
Copy link
Member

ijjk commented Jan 7, 2025 •
edited
Loading

Stats from current PR

Default Build (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary vercel/next.js 01-07-_devoverlay_add_floating_header Change
buildDuration 28.6s 25.6s N/A
buildDurationCached 23.5s 20.6s N/A
nodeModulesSize 416 MB 416 MB ⚠️ +46.2 kB
nextStartRea..uration (ms) 856ms 791ms N/A
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js 01-07-_devoverlay_add_floating_header Change
5306-HASH.js gzip 53.3 kB 53.3 kB N/A
8276.HASH.js gzip 169 B 168 B N/A
8377-HASH.js gzip 5.44 kB 5.44 kB N/A
bccd1874-HASH.js gzip 53 kB 53 kB ✓
framework-HASH.js gzip 57.5 kB 57.5 kB N/A
main-app-HASH.js gzip 241 B 241 B ✓
main-HASH.js gzip 34.1 kB 34.1 kB N/A
webpack-HASH.js gzip 1.71 kB 1.71 kB N/A
Overall change 53.2 kB 53.2 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js 01-07-_devoverlay_add_floating_header Change
polyfills-HASH.js gzip 39.4 kB 39.4 kB ✓
Overall change 39.4 kB 39.4 kB ✓
Client Pages
vercel/next.js canary vercel/next.js 01-07-_devoverlay_add_floating_header Change
_app-HASH.js gzip 193 B 193 B ✓
_error-HASH.js gzip 193 B 193 B ✓
amp-HASH.js gzip 512 B 510 B N/A
css-HASH.js gzip 343 B 342 B N/A
dynamic-HASH.js gzip 1.84 kB 1.84 kB ✓
edge-ssr-HASH.js gzip 265 B 265 B ✓
head-HASH.js gzip 363 B 362 B N/A
hooks-HASH.js gzip 393 B 392 B N/A
image-HASH.js gzip 4.57 kB 4.57 kB N/A
index-HASH.js gzip 268 B 268 B ✓
link-HASH.js gzip 2.35 kB 2.34 kB N/A
routerDirect..HASH.js gzip 328 B 328 B ✓
script-HASH.js gzip 397 B 397 B ✓
withRouter-HASH.js gzip 323 B 326 B N/A
1afbb74e6ecf..834.css gzip 106 B 106 B ✓
Overall change 3.59 kB 3.59 kB ✓
Client Build Manifests
vercel/next.js canary vercel/next.js 01-07-_devoverlay_add_floating_header Change
_buildManifest.js gzip 749 B 747 B N/A
Overall change 0 B 0 B ✓
Rendered Page Sizes
vercel/next.js canary vercel/next.js 01-07-_devoverlay_add_floating_header Change
index.html gzip 522 B 521 B N/A
link.html gzip 538 B 535 B N/A
withRouter.html gzip 518 B 518 B ✓
Overall change 518 B 518 B ✓
Edge SSR bundle Size
vercel/next.js canary vercel/next.js 01-07-_devoverlay_add_floating_header Change
edge-ssr.js gzip 128 kB 128 kB N/A
page.js gzip 207 kB 207 kB N/A
Overall change 0 B 0 B ✓
Middleware size
vercel/next.js canary vercel/next.js 01-07-_devoverlay_add_floating_header Change
middleware-b..fest.js gzip 670 B 668 B N/A
middleware-r..fest.js gzip 155 B 156 B N/A
middleware.js gzip 31.2 kB 31.2 kB N/A
edge-runtime..pack.js gzip 844 B 844 B ✓
Overall change 844 B 844 B ✓
Next Runtimes Overall increase ⚠️
vercel/next.js canary vercel/next.js 01-07-_devoverlay_add_floating_header Change
274-experime...dev.js gzip 322 B 322 B ✓
274.runtime.dev.js gzip 314 B 314 B ✓
app-page-exp...dev.js gzip 367 kB 367 kB ⚠️ +108 B
app-page-exp..prod.js gzip 129 kB 129 kB ✓
app-page-tur..prod.js gzip 142 kB 142 kB ✓
app-page-tur..prod.js gzip 138 kB 138 kB ✓
app-page.run...dev.js gzip 355 kB 355 kB ⚠️ +116 B
app-page.run..prod.js gzip 126 kB 126 kB ✓
app-route-ex...dev.js gzip 37.6 kB 37.6 kB ✓
app-route-ex..prod.js gzip 25.6 kB 25.6 kB ✓
app-route-tu..prod.js gzip 25.6 kB 25.6 kB ✓
app-route-tu..prod.js gzip 25.4 kB 25.4 kB ✓
app-route.ru...dev.js gzip 39.2 kB 39.2 kB ✓
app-route.ru..prod.js gzip 25.4 kB 25.4 kB ✓
pages-api-tu..prod.js gzip 9.69 kB 9.69 kB ✓
pages-api.ru...dev.js gzip 11.6 kB 11.6 kB ✓
pages-api.ru..prod.js gzip 9.68 kB 9.68 kB ✓
pages-turbo...prod.js gzip 21.7 kB 21.7 kB ✓
pages.runtim...dev.js gzip 27.5 kB 27.5 kB ✓
pages.runtim..prod.js gzip 21.7 kB 21.7 kB ✓
server.runti..prod.js gzip 916 kB 916 kB ✓
Overall change 2.46 MB 2.46 MB ⚠️ +224 B
build cache Overall increase ⚠️
vercel/next.js canary vercel/next.js 01-07-_devoverlay_add_floating_header Change
0.pack gzip 2.09 MB 2.1 MB ⚠️ +3.04 kB
index.pack gzip 74.8 kB 75 kB ⚠️ +161 B
Overall change 2.17 MB 2.17 MB ⚠️ +3.2 kB
Diff details
Diff for main-HASH.js

Diff too large to display

Diff for app-page-exp..ntime.dev.js 
failed to diff
Diff for app-page.runtime.dev.js 
failed to diff
Commit: 00a0d28

@ijjk
Copy link
Member

ijjk commented Jan 7, 2025 •
edited
Loading

Tests Passed

@devjiwonchoi devjiwonchoi mentioned this pull request Jan 7, 2025
Merged
@devjiwonchoi devjiwonchoi force-pushed the 01-07-_devoverlay_add_docs_link_button branch 2 times, most recently from 15bf9f0 to 57e4e81 Compare January 7, 2025 15:24
@devjiwonchoi devjiwonchoi force-pushed the 01-07-_devoverlay_add_floating_header branch from 3b50087 to c4d42c9 Compare January 7, 2025 15:24
@devjiwonchoi devjiwonchoi force-pushed the 01-07-_devoverlay_add_docs_link_button branch from 57e4e81 to b1dcfb5 Compare January 7, 2025 15:27
@devjiwonchoi devjiwonchoi force-pushed the 01-07-_devoverlay_add_floating_header branch from c4d42c9 to a1642a2 Compare January 7, 2025 15:27
@devjiwonchoi devjiwonchoi mentioned this pull request Jan 7, 2025
Merged
@devjiwonchoi devjiwonchoi force-pushed the 01-07-_devoverlay_add_docs_link_button branch from b1dcfb5 to 9572703 Compare January 7, 2025 17:58
@devjiwonchoi devjiwonchoi force-pushed the 01-07-_devoverlay_add_floating_header branch from 1876daa to ede9f89 Compare January 7, 2025 17:59
This was referenced Jan 7, 2025
Merged
Merged
Merged
@devjiwonchoi devjiwonchoi force-pushed the 01-07-_devoverlay_add_floating_header branch from ede9f89 to 3167e00 Compare January 8, 2025 14:00
@devjiwonchoi devjiwonchoi mentioned this pull request Jan 8, 2025
Merged
@devjiwonchoi devjiwonchoi changed the base branch from 01-07-_devoverlay_add_docs_link_button to graphite-base/74581 January 9, 2025 04:43
@devjiwonchoi devjiwonchoi force-pushed the 01-07-_devoverlay_add_floating_header branch from 3167e00 to 4b76331 Compare January 9, 2025 04:43
@devjiwonchoi devjiwonchoi changed the base branch from graphite-base/74581 to canary January 9, 2025 04:44
@devjiwonchoi devjiwonchoi force-pushed the 01-07-_devoverlay_add_floating_header branch 2 times, most recently from ff112b2 to 6780089 Compare January 9, 2025 07:24
@devjiwonchoi devjiwonchoi mentioned this pull request Jan 9, 2025
Merged
@devjiwonchoi devjiwonchoi force-pushed the 01-07-_devoverlay_add_floating_header branch 2 times, most recently from 4dc12a6 to 2b3d79b Compare January 10, 2025 06:55
@devjiwonchoi devjiwonchoi changed the title [DevOverlay] Add floating header [DevOverlay] Floating Header and Bottom Stacks Jan 10, 2025
@devjiwonchoi devjiwonchoi force-pushed the 01-07-_devoverlay_add_floating_header branch from ecf84ac to f3d9971 Compare January 10, 2025 09:03
@eps1lon

This comment was marked as outdated.

Sign in to view
eps1lon
eps1lon approved these changes Jan 10, 2025
View reviewed changes
Copy link
Member

@eps1lon eps1lon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Proper pagination comes in #74583

@devjiwonchoi devjiwonchoi merged commit 67c3d7a into canary Jan 10, 2025
127 of 132 checks passed
@devjiwonchoi devjiwonchoi deleted the 01-07-_devoverlay_add_floating_header branch January 10, 2025 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eps1lon eps1lon eps1lon approved these changes

@huozhi huozhi Awaiting requested review from huozhi

@gaojude gaojude Awaiting requested review from gaojude

Assignees
No one assigned
Labels
created-by: Next.js team PRs by the Next.js team. type: next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@devjiwonchoi @ijjk @eps1lon